-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add module-info.java to eclipse null annotations #2539
base: master
Are you sure you want to change the base?
Add module-info.java to eclipse null annotations #2539
Conversation
Some questions while I'm trying to understand the motivation:
|
It breaks. It does not support automatic modules.
They are not needed assuming you just stick to the annotations but sadly it is tricky across Maven and Gradle to make sure the jar does not get picked up. I had to exclude the dependency and do a
I didn't even try putting in a real |
Java 17 :) |
So, there's the rub: currently this plugin targets JavaSE-1.8, but it may actually be the last one far and wide. Most plugins of JDT currently target JavaSE-17. As for javac versions: we don't use javac at all 😄, but ecj. And I know tycho is frequently updating the version, so I guess that tycho would allow compiling even for Java 22. So, when you try adding a real module-info.java you should
|
Yes I was pretty sure it was ecj. What I meant by not knowing what it supported is if it (tycho + ecj) supports multi-release jars for the case of having annotations jar still support JDK 8 but if we don't need to worry about that (as in we can update it to 11) then I will attempt to do the update path you recommend and update the PR. |
This change just adds a module-info.java
What it does
See #2538 . It adds a module-info.java to the eclipse annotations jar.
How to test
Create a jlink bundled application that uses
org.eclipse.jdt.annotation
module.Author checklist
The following is not really applicable.