-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Oomph-Setup] Add jdt.debug configuration setup #533
Conversation
Additionally add a styled and drag&drop-able Oomph Configuration button to the main README. Part of eclipse-platform/eclipse.platform.releng.aggregator#2430
191a204
to
e88c1b7
Compare
@jukzi or @iloveeclipse, could you please submit this as well? Thanks in advance. |
<description>The JDT Debug workspace provides all the source code of the project.</description> | ||
</workspace> | ||
<description> | ||
<p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is "<" encoded with lt but ">" is not gt encoded?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Oomph-Editor is doing this. I assume it's not necessary.
It's the same for other configurations as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also in exiting configurations i can not read such fields:
it's illegal xml. @merks can you fix that?
I'll be AFK 2w
The only problem I see is that these PRs need to be merged: #533 That's the reason for these three broken references: Could you please merge those too? It's normal that only up to the first newline character is shown in the properties view. The cell editor shows the whole text: The hover also shows it nicely formatted: As does this page: So no, a > is not invalid XML in element content. That's why EMF does not escape them for element content: But does for attribute content: |
ok, in this case it is not invalid. while in general it may be invalid. So i would always encode it to be on the valid side, but that doesn't matter for this pr. |
In general it's never invalid in element content. Moreover, EMF has done it this way for 25 years without anyone ever suggesting it should be changed. If it ain't broke, don't fix it. 😬 |
Thank you Jörg for submitting this! The results look good and as expected: And if you click it, the installer page looks good too: |
Cool. 😎 |
FYI, the corner cases are handled properly by EMF: |
What it does
Add jdt.debug configuration setup.
Additionally add a styled and drag&drop-able Oomph Configuration button to the main README.
Part of eclipse-platform/eclipse.platform.releng.aggregator#2430
Author checklist