-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ASM Upgrade 9.7.1 with Java 24 Opcode support #542
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how is javaagent-shaded.jar created?
import org.objectweb.asm.ClassVisitor; | ||
import org.objectweb.asm.ClassWriter; | ||
import org.objectweb.asm.Opcodes; | ||
import org.eclipse.jdt.launching.internal.org.objectweb.asm.ClassReader; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where do these Classes come from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was throwing some errors with existing imports, so did quick fix for that. should I revert that then ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If possible could you try the same ? generating a new javaagent-shaded file, maybe I did some mistake while doing it..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when i create the jar it looks the same. Also Readme.md describes that
Note that ASM classes are _relocated_ to
org.eclipse.jdt.launching.internal.org.objectweb.asm package to avoid possible conflicts with applicates being debugged.
however it should not change the source and i still don't get why the CI does not complain about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i guess org.eclipse.jdt.launching.javaagent is missing in pom.xml so that it is not compiled by CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when i create the jar it looks the same. Also Readme.md describes that
Note that ASM classes are _relocated_ to
org.eclipse.jdt.launching.internal.org.objectweb.asmpackage to avoid possible conflicts with applicates being debugged.
however it should not change the source and i still don't get why the CI does not complain about it.
so is it some issue with the jar ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jukzi, I have changed the imports to defaults now
Created by running "mvn clean package" command from debug's jdt.launching.javaagent |
What it does
#540
How to test
Author checklist