ASM Upgrade 9.7.1 with Java 24 Opcode support #542
Conversation
| import org.objectweb.asm.ClassVisitor; | ||
| import org.objectweb.asm.ClassWriter; | ||
| import org.objectweb.asm.Opcodes; | ||
| import org.eclipse.jdt.launching.internal.org.objectweb.asm.ClassReader; |
There was a problem hiding this comment.
where do these Classes come from?
There was a problem hiding this comment.
It was throwing some errors with existing imports, so did quick fix for that. should I revert that then ?
There was a problem hiding this comment.
i wonder why it compiles on CI but not for me locally:
There was a problem hiding this comment.
If possible could you try the same ? generating a new javaagent-shaded file, maybe I did some mistake while doing it..
There was a problem hiding this comment.
probably... that jar is wrong:
There was a problem hiding this comment.
when i create the jar it looks the same. Also Readme.md describes that
Note that ASM classes are _relocated_ to org.eclipse.jdt.launching.internal.org.objectweb.asm package to avoid possible conflicts with applicates being debugged.
however it should not change the source and i still don't get why the CI does not complain about it.
There was a problem hiding this comment.
i guess org.eclipse.jdt.launching.javaagent is missing in pom.xml so that it is not compiled by CI
There was a problem hiding this comment.
when i create the jar it looks the same. Also Readme.md describes that
Note that ASM classes are _relocated_ toorg.eclipse.jdt.launching.internal.org.objectweb.asmpackage to avoid possible conflicts with applicates being debugged.however it should not change the source and i still don't get why the CI does not complain about it.
so is it some issue with the jar ?
There was a problem hiding this comment.
Hi @jukzi, I have changed the imports to defaults now
Created by running "mvn clean package" command from debug's jdt.launching.javaagent |
What it does
#540
How to test
Author checklist