Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle potential NumberFormatException in chain completion settings. #1196

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Handle potential NumberFormatException in chain completion settings. #1196

merged 1 commit into from
Feb 15, 2024

Conversation

rgrunber
Copy link
Contributor

@rgrunber
Handle potential NumberFormatException in chain completion settings.
799b12a 
- More generally, handling of improper values in certain cases where the
  JDT UI preference initialization fails to set preferences

Signed-off-by: Roland Grunberg <[email protected]>
@rgrunber rgrunber requested a review from jukzi February 15, 2024 00:09
@rgrunber
Copy link
Contributor Author

rgrunber commented Feb 15, 2024 •
edited
Loading

I think the last build for M3 was today at 18:00 EST, so we can target RC1 and all that's needed is a review.

@jukzi jukzi merged commit fbb9338 into eclipse-jdt:master Feb 15, 2024
9 checks passed
@rgrunber rgrunber deleted the null-chain-comp-prefs branch February 15, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jukzi jukzi jukzi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Java Code Assist: javaCompletionProposal throws runtime exception
2 participants
@rgrunber @jukzi