Add unit test for regression fix (#1651) #1655
Open
+28
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cool |
|
The test run https://github.com/eclipse-jdt/eclipse.jdt.ui/pull/1655/checks?check_run_id=30276996999 shows the expected failure for the newly added test because this PR was tested before #1653 was merged. I think the second test failure is transient. There are some issues that sound like they could be related, e.g. #1445 and #79. Rebasing this PR should show that the newly added test passes. I already tested this locally. |
jukzi
force-pushed
the
issue-1651-add-unit-test-for-regression-fix
branch
from
9557b7d
to
52f620b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
The regression #1651 is fixed by #1653 by @jukzi . This adds a unit test for the fix in #1653.
How to test
The test case should run automatically in the build.
Author checklist