Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter problem of accidental extra version increment #1699

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

merks
Copy link
Contributor

@merks merks commented Oct 5, 2024

@merks
Copy link
Contributor Author

merks commented Oct 5, 2024

@akurtakov @jjohnstn

I don't think the problems where relate to my changes.

@iloveeclipse
Copy link
Member

I don't think the problems where relate to my changes.

Surely not. Thanks Ed.

@iloveeclipse iloveeclipse merged commit 8f8fafd into eclipse-jdt:master Oct 7, 2024
7 of 10 checks passed
@jjohnstn
Copy link
Contributor

jjohnstn commented Oct 7, 2024

@iloveeclipse I did see that there was a version bump and was going to comment but I also saw from @fedejeanne that it fixed the PR build error. Is there an issue with the PR version checking or was this just a hiccup?

@iloveeclipse
Copy link
Member

@iloveeclipse I did see that there was a version bump and was going to comment but I also saw from @fedejeanne that it fixed the PR build error. Is there an issue with the PR version checking or was this just a hiccup?

The problem was real and Ed "fixed" it via API filter, thanks Ed!

Ideally one should rebase every PR before merging or check it locally on latest head to avoid such problems in the future.

@jjohnstn
Copy link
Contributor

jjohnstn commented Oct 7, 2024

My bad for merging. Thanks Ed.

@fedejeanne
Copy link
Contributor

@jjohnstn sorry for the inconvenience! I'm trying to learn how to avoid this in the future so it doesn't fall on your lap (or on the lap of any other committer) in the future --> eclipse-platform/eclipse.platform.releng.aggregator#2406

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants