Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix smart paste to not import when pasting into string or text block #1732

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

jjohnstn
Copy link
Contributor

What it does

See issue.

How to test

See issue or paste a section of code that uses imported classes into a text block or string literal.

Author checklist

- fix ClipBoardOperationAction.doPasteWithImports() to check if target
  is in a String or text block in which case do not add imports
- fixes eclipse-jdt#1716
@jjohnstn jjohnstn self-assigned this Oct 22, 2024
@jjohnstn jjohnstn added the bug Something isn't working label Oct 22, 2024
@jjohnstn jjohnstn added this to the 4.34 M3 milestone Oct 22, 2024
@jjohnstn
Copy link
Contributor Author

Known test failure.

@jjohnstn jjohnstn merged commit 348433b into eclipse-jdt:master Oct 23, 2024
7 of 10 checks passed
@jjohnstn jjohnstn deleted the smartpastebug branch October 23, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

copy code lines to a text block adds imports to the java class the text block is part of
1 participant