[Dark Theme] Fix for bg color of bread crumb in editor #1844
Conversation
|
@jukzi: Can you pls. review and merge? |
jukzi
force-pushed
the
fix_breadcrumb_dark_theme
branch
from
530f416 to
45f01ea
Compare
We refuse mere until CI is green again. You can help by solving underlying errors in platform.ui |
What is the underying issue in platform? |
|
I see this in the "Tests / Build":
This is an JDT test that fails. So I don't see that this is a platform issue. Or do I overlook something? |
see #1843 errors in platform pop up in jdt, |
So I see that a fix is on it's way with: eclipse-platform/eclipse.platform.ui#2612 |
yey, so please help to get that one green. |
As we changed the background color of editor to more darker shade, background of breadcrumbs were still using the older color code. This has been changed to same color code as editor's.
jukzi
force-pushed
the
fix_breadcrumb_dark_theme
branch
from
45f01ea to
38e830c
Compare
|
Thanks for merging |
As we changed the background color of the editor to a darker shade, the background of the breadcrumbs was still using the older color code. This has been changed to the same color code as the editor's.
Before:
After:
