Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing bugs of extract method refactoring #901

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

larjean89
Copy link

@larjean89 larjean89 commented Nov 3, 2023

What it does

  • restricts the extraction of methods where multiple exits exist
  • solved the issue

How to test

Run test3000, test3001 and test3002 in ExtractMethodTests

Author checklist

@jjohnstn
Copy link
Contributor

jjohnstn commented Nov 3, 2023

Hi @larjean89 I see you made some of the recommended changes. You still need to remove the binary classes in the patch, plus remove the change to the binary/.gitignore. You also inadvertently removed the copyright info for ExtractMethodTests. In addition, you will have to rebase the whole patch on recent origin/master which will have a number of conflicts in ExtractMethodAnalyzer. Do not merge master into your patch. Once you have the rebase complete use git push --force to replace your previous patches as it is likely a regular push will tell you the changes aren't forward.

@larjean89 larjean89 force-pushed the FixingBugsOfExtractMethodRefactoring branch from e9385c3 to 90aff68 Compare November 4, 2023 09:54
@larjean89
Copy link
Author

@jjohnstn how is this commit looking now. I have tried to address some of the issues raised. Kindly advise.

@jjohnstn
Copy link
Contributor

/rebase

@github-actions github-actions bot force-pushed the FixingBugsOfExtractMethodRefactoring branch from 90aff68 to cb5c141 Compare November 20, 2023 15:31
@jjohnstn jjohnstn modified the milestones: 4.31, 4.31 M1 Nov 27, 2023
@jjohnstn
Copy link
Contributor

jjohnstn commented Dec 5, 2023

/rebase

@jjohnstn jjohnstn force-pushed the FixingBugsOfExtractMethodRefactoring branch from cb5c141 to 0116df8 Compare December 6, 2023 20:57
@jukzi
Copy link
Contributor

jukzi commented Jan 31, 2024

the tests show 4 failed tests (AssistQuickFixTest1d8). please fix
https://ci.eclipse.org/jdt/job/eclipse.jdt.ui-github/job/PR-901/4/testReport/

@jjohnstn jjohnstn removed this from the 4.31 M1 milestone Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants