Fix ConnectionStreamFactory with javac #3258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snjeza
requested review from
fbricon,
mickaelistria,
rgrunber,
jdneo and
testforstephen
|
That might probably work. However, I fail at understanding why it's OK with current master, while it's failing in the javac branch. Do you have any idea what the cause can be? In the PR enabling javac branch ( #3167 ), some compiler configuration seems to be added. Is this causing the difference? |
|
Anyway, I could verify this works and this really seems like a difference between ECJ (used by default) and javac (used with Java 23). I cannot tell which one is wrong here, and I don't really care since this patch works with both ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to eclipse-jdtls/eclipse-jdt-core-incubator#609