Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify LINE_BREAKS on tokens with custom patterns #1685

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

aabounegm
Copy link
Member

A warning was printed by Chevrotain for keyword tokens using a custom matcher function for the pattern.
While the default implementation does not use a custom matcher function, it is possible to override buildKeywordPattern to return one.

A warning was printed by Chevrotain for tokens using a custom matcher
function for the keyword pattern.
While this doesn't happen in the default implementation, it is possible
to override `buildKeywordPattern` and use a custom matcher function
@msujew msujew self-requested a review October 2, 2024 15:28
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

While we're at it, do you think we can do the same for the terminal tokens?

@aabounegm
Copy link
Member Author

Sure thing

Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you :)

@msujew msujew changed the title Specify line_breaks on tokens with custom patterns Specify LINE_BREAKS on tokens with custom patterns Oct 8, 2024
@msujew msujew merged commit 4bb3e78 into eclipse-langium:main Oct 8, 2024
4 checks passed
@aabounegm aabounegm deleted the fix/line-breaks-warning branch October 8, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants