Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get tabWidth / insertSpaces from editor preferences store #271

Closed
wants to merge 1 commit into from
Closed

Get tabWidth / insertSpaces from editor preferences store #271

wants to merge 1 commit into from

Conversation

angelozerr
Copy link
Contributor

@angelozerr angelozerr commented Oct 28, 2022 •
edited
Loading

Get tabWidth / insertSpaces from editor preferences store

Fixes #245

Signed-off-by: azerr [email protected]

@angelozerr
Copy link
Contributor Author

This PR provides the capability to get the tabWidth / insertSpaces from the editor preference store and if it find nothing, it use the global settings from Eclipse IDE.

It will give the capability to customize the insert spaces / tabs with UI preferences and .editorconfig, but it requires some changes on Platform Text I created a draft PR for that eclipse-platform/eclipse.platform.text#109

@angelozerr angelozerr force-pushed the custom-insert-spaces branch from 0b277a5 to a533373 Compare October 28, 2022 07:59
rubenporras
rubenporras requested changes Nov 1, 2022
View reviewed changes
Copy link
Contributor

@rubenporras rubenporras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, but some test do not compile any more. Could you take a look at those?

@angelozerr angelozerr force-pushed the custom-insert-spaces branch 2 times, most recently from 1b7f08a to 5db3d86 Compare November 1, 2022 20:53
@angelozerr
Copy link
Contributor Author

Even if this code works without some changes from Platform, it will use every time EditorUI preference store, but I think before merging this PR, @mickaelistria should be OK to merge this little PR eclipse-platform/eclipse.platform.text#88 (see my comment at eclipse-platform/eclipse.platform.text#88 (comment))

@angelozerr
Copy link
Contributor Author

The code looks good, but some test do not compile any more. Could you take a look at those?

It should work now (CI build has successed)

@rubenporras
Copy link
Contributor

Agree, let us Mickael decide. Thanks for the clarification.

@angelozerr angelozerr force-pushed the custom-insert-spaces branch 7 times, most recently from 806607a to d7d52d5 Compare April 3, 2023 12:15
@sebthom
Copy link
Contributor

sebthom commented May 17, 2024

@angelozerr is this PR still something you are working on or shall we close it?

@angelozerr
Copy link
Contributor Author

Im sorry I have no time to work on it. You can close it if you wish.

@sebthom sebthom closed this May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubenporras rubenporras rubenporras requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Read from the editor preference store, not the global preference store, to retrieve formatting settings
3 participants
@angelozerr @rubenporras @sebthom