-
Notifications
You must be signed in to change notification settings - Fork 115
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Don't extract referenced bundles for Maven runtime classpath
Fixes #923 OSGi bundles that are referenced by the m2e.maven.runtime bundle don't have to be extracted when added to the classpath of an about to be launched Maven build. Not extracting them significantly speeds up the launch of the first build after IDE start or opening the first time the Launch-Config dialog for Maven builds or the Maven Installation settings. Additionally ensure that slf4j from Maven-Central is used instead of the one from Orbit to prevent errors like the following when launching a Maven-build with the embedded runtime from the IDE: """ class "org.slf4j.MavenSlf4jFriend"'s signer information does not match signer information of other classes in the same package """ The reason for that error is that the slf4j variant from Orbit is jar-signed by Eclipse, while 'slf4j' and 'maven-slf4j-provider' from Maven-Central is only PGP-signed (and not jarsigned). But because 'slf4j' and 'maven-slf4j-provider' provide classes for the package org.slf4j they must provide the same signer information. This check is not performed if a jar is extracted and added to the classpath as directory, but we don't want to do that anymore.
- Loading branch information
1 parent
2a214b2
commit e6f8afc
Showing
4 changed files
with
22 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
[submodule "m2e-core-tests"] | ||
path = m2e-core-tests | ||
url = https://github.com/tesla/m2e-core-tests.git | ||
branch = master | ||
url = https://github.com/HannesWell/m2e-core-tests.git | ||
branch = slf4jInTests |
Submodule m2e-core-tests
updated
1 files
+20 −24 | org.eclipse.m2e.tests/src/org/eclipse/m2e/tests/embedder/MavenRuntimeManagerTest.java |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters