Prevent commoning conversion to address operations in LocalCSE #7218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OMR::LocalCSE::canBeAvailable was restricting l2a operations from being commoned to reduce the likelihood that a register holding the result of such an operation would be marked as a collected reference and kept live across a GC point by l2aEvaluator. To be safest, all conversion to address types should be similarly prevented from being commoned.
|
@vijaysun-omr, may I ask you to review this change? Jenkins build all |
|
Failure in x86-64 macOS testing is due to issue #7181. |
vijaysun-omr
approved these changes
Jan 8, 2024
|
I think it may be good to get a quick review from @jdmpapin too for this PR so that he is in the loop on the short term solution being adopted (I think he had a long term view that Henry documented in the issue for the failure seen recently). |
jdmpapin
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OMR::LocalCSE::canBeAvailablewas restrictingl2aoperations from being commoned to reduce the likelihood that a register holding the result of such an operation would be marked as a collected reference and kept live across a GC point by l2aEvaluator. To be safest, all conversion to address types should be similarly prevented from being commoned.This change generalizes the change delivered under pull request #7217.