Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove remaining q uses #19799

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Remove remaining q uses #19799

merged 1 commit into from
Jul 8, 2024

Conversation

theresa-m
Copy link
Contributor

Related to #18157

@theresa-m theresa-m requested a review from dsouzai as a code owner July 3, 2024 17:12
@theresa-m theresa-m added comp:vm comp:jit project:valhalla Used to track Project Valhalla related work labels Jul 3, 2024
@a7ehuo a7ehuo mentioned this pull request Jul 3, 2024
Merged
@theresa-m theresa-m mentioned this pull request Jul 3, 2024
Open
a7ehuo
a7ehuo reviewed Jul 3, 2024
View reviewed changes
Copy link
Contributor

@a7ehuo a7ehuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in the JIT look good to me. Thank you very much for the update @theresa-m!

Just noticed two more comments related to Q type that could be deleted as well

openj9/runtime/compiler/env/J9ClassEnv.hpp

Lines 132 to 133 in c795e21

* - null-free class type (Q) that are not both flattened and recursively
* compatible for direct memory comparison

openj9/runtime/compiler/control/JITServerHelpers.cpp

Lines 1529 to 1530 in c795e21

// Note that for object arrays we can simply use the "L" type signature since the distinction with "Q" types
// is ignored during array class lookup by name (see internalFindArrayClass() in runtime/vm/classsupport.c).

@hzongaro fyi

@theresa-m
Copy link
Contributor Author

Thanks for finding those @a7ehuo please double check I updated them in a way that makes sense.

a7ehuo
a7ehuo approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@a7ehuo a7ehuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The JIT changes LGTM. Thank you for the update @theresa-m!

hangshao0
hangshao0 reviewed Jul 5, 2024
View reviewed changes
runtime/oti/j9.h Outdated Show resolved Hide resolved
@theresa-m
Remove remaining q uses
36f35ec 
Signed-off-by: Theresa Mammarella <[email protected]>
@hangshao0
Copy link
Contributor

Jenkins test sanity,extended zlinuxval jdknext

@hangshao0
Copy link
Contributor

Jenkins test sanity,extended amac jdk21

@hangshao0 hangshao0 merged commit dd108db into eclipse-openj9:master Jul 8, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hangshao0 hangshao0 hangshao0 approved these changes

@a7ehuo a7ehuo a7ehuo approved these changes

@dsouzai dsouzai Awaiting requested review from dsouzai dsouzai is a code owner

Assignees
No one assigned
Labels
comp:jit comp:vm project:valhalla Used to track Project Valhalla related work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theresa-m @hangshao0 @a7ehuo