Fix null restricted array related issues for value types #20112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a7ehuo
added
comp:jit
project:valhalla
a7ehuo
force-pushed
the
PR-valuetypes-null-restricted-array
branch
2 times, most recently
from
c469e30
to
516a676
Compare
1 task
|
@hzongaro May I ask you to review this change? Thank you very much! This PR is created as a draft and marked as WIP for now because of all the dependencies. Regarding to the implementation itself, it is ready for review. Since this PR depends on eclipse/omr#7452, it should be review along with eclipse/omr#7452. |
hzongaro
reviewed
Sep 9, 2024
hzongaro
reviewed
Sep 9, 2024
a7ehuo
force-pushed
the
PR-valuetypes-null-restricted-array
branch
from
516a676
to
bb24a35
Compare
Whether or not an array is null-restricted is no longer decided by array component type but by the J9ClassArrayIsNullRestricted flag in array class. Only the nullRestrictedArrayClass of the J9Class has J9ClassArrayIsNullRestricted set. (1) Add getNullRestrictedArrayClassFromComponentClass to retrieve nullRestrictedArrayClass from J9Class (2) Add isArrayNullRestricted to check if an array class is null restricted by checking J9ClassArrayIsNullRestricted. Signed-off-by: Annabelle Huo <[email protected]>
(1) Add recognized methods from jdk/internal/value/ValueClass (2) Add VP fixed class constraint if ValueClass.newArrayInstance creates null restricted array using NullRestrictedCheckedType (3) Rename isArrayCompTypePrimitiveValueType to isArrayNullRestricted to reflect the updated logic Update isArrayNullRestricted on how to determine whether or not an array is a null restricted array (4) Disable transformation based on type hint which is no longer sufficient enough to decide whether or not the array is null restricted or not (5) If flattenable arrays are enabled, do not create fixed class constraint for parm array class based on signature since both nullable and null restricted arrays share the same signature (6) Enable previous disabled JIT Valhalla functional tests Fixes: eclipse-openj9#19913, eclipse-openj9#19914, eclipse-openj9#19708 Signed-off-by: Annabelle Huo <[email protected]>
a7ehuo
force-pushed
the
PR-valuetypes-null-restricted-array
branch
from
bb24a35
to
3af4ff9
Compare
a7ehuo
changed the title
|
@hzongaro All comments have been addressed in the latest commits, except for the following three that will be addressed in the future PRs due to the complexity. Ready for another review. Thank you! (1) #20112 (comment) Please note that I have rebased this PR to the latest master branch and this PR requires coordinated merge with eclipse/omr#7452. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(1) Add utility methods for null restricted arrays
(2) Fix null restricted array related issues
jdk/internal/value/ValueClass.newArrayInstanceValueClass.newArrayInstancecreates null restricted arrayisArrayCompTypePrimitiveValueTypetoisArrayNullRestrictedto reflect the updated logicisArrayNullRestrictedon how to determine whether or not an array is a null restricted arrayDepends on
Fixes: #19913, #19914, #19708