-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Unnecessary Assertion in removeHCRGuards #20292
Open
luke-li-2003
wants to merge
8
commits into
eclipse-openj9:master
Choose a base branch
from
luke-li-2003:RemoveHCRGuardsAssert
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Remove Unnecessary Assertion in removeHCRGuards #20292
luke-li-2003
wants to merge
8
commits into
eclipse-openj9:master
from
luke-li-2003:RemoveHCRGuardsAssert
Commits on Oct 2, 2024
-
Remove Unnecessary Assertion in removeHCRGuards
The assertion "!guardInfo->getByteCodeInfo().isInvalidByteCodeIndex()" is obsolete and not needed since the function does not actual access a ByteCodeInfo anywhere. It fails incorrectly when a "TR_SideEffectGuard" is encountered. Signed-off-by: Luke Li <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6c8fb42 - Browse repository at this point
Copy the full SHA 6c8fb42View commit details
Commits on Oct 3, 2024
-
Merge branch 'master' of https://github.com/eclipse-openj9/openj9 int…
…o RemoveHCRGuardsAssert
Configuration menu - View commit details
-
Copy full SHA for e6fd380 - Browse repository at this point
Copy the full SHA e6fd380View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d1a86a - Browse repository at this point
Copy the full SHA 0d1a86aView commit details
Commits on Oct 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c6cd286 - Browse repository at this point
Copy the full SHA c6cd286View commit details -
Configuration menu - View commit details
-
Copy full SHA for c2c87a0 - Browse repository at this point
Copy the full SHA c2c87a0View commit details
Commits on Oct 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9c48555 - Browse repository at this point
Copy the full SHA 9c48555View commit details -
Configuration menu - View commit details
-
Copy full SHA for 782c83a - Browse repository at this point
Copy the full SHA 782c83aView commit details -
Configuration menu - View commit details
-
Copy full SHA for f094243 - Browse repository at this point
Copy the full SHA f094243View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.