JDK 24 remove java.security.AccessController.doPrivileged part 1 #21042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theresa-m
force-pushed
the
securitymanager_4
branch
from
2430b36 to
0880427
Compare
JasonFengJ9
reviewed
Jan 30, 2025
jcl/src/java.base/share/classes/com/ibm/oti/util/PriviAction.java
Outdated
Show resolved
Hide resolved
jcl/src/java.base/share/classes/com/ibm/oti/util/RuntimePermissions.java
Outdated
Show resolved
Hide resolved
jcl/src/java.base/share/classes/java/lang/RuntimePermission.java
Outdated
Show resolved
Hide resolved
...c/java.management/share/classes/com/ibm/java/lang/management/internal/LoggingMXBeanImpl.java
Outdated
Show resolved
Hide resolved
...c/java.management/share/classes/com/ibm/java/lang/management/internal/LoggingMXBeanImpl.java
Outdated
Show resolved
Hide resolved
jcl/src/jdk.attach/share/classes/com/ibm/tools/attach/attacher/OpenJ9AttachProvider.java
Show resolved
Hide resolved
jcl/src/java.base/share/classes/openj9/internal/criu/InternalCRIUSupport.java
Show resolved
Hide resolved
jcl/src/java.base/share/classes/openj9/internal/criu/InternalCRIUSupport.java
Outdated
Show resolved
Hide resolved
keithc-ca
requested changes
Jan 30, 2025
.../jdk.management/share/classes/com/ibm/lang/management/internal/ExtendedMemoryMXBeanImpl.java
Outdated
Show resolved
Hide resolved
...rc/jdk.management/share/classes/com/ibm/lang/management/internal/ExtendedThreadInfoImpl.java
Outdated
Show resolved
Hide resolved
.../jdk.management/share/classes/com/ibm/lang/management/internal/MemoryNotificationThread.java
Outdated
Show resolved
Hide resolved
...gement/share/classes/com/ibm/lang/management/internal/OperatingSystemNotificationThread.java
Show resolved
Hide resolved
jcl/src/jdk.management/share/classes/com/sun/management/internal/GcInfoUtil.java
Outdated
Show resolved
Hide resolved
theresa-m
force-pushed
the
securitymanager_4
branch
3 times, most recently
from
19a0138 to
a0cbf2a
Compare
keithc-ca
requested changes
Jan 31, 2025
jcl/src/java.base/share/classes/openj9/internal/criu/InternalCRIUSupport.java
Outdated
Show resolved
Hide resolved
jcl/src/java.base/share/classes/openj9/internal/criu/InternalCRIUSupport.java
Show resolved
Hide resolved
jcl/src/java.management/share/classes/java/lang/management/PlatformLoggingMXBean.java
Outdated
Show resolved
Hide resolved
jcl/src/jdk.attach/share/classes/com/ibm/tools/attach/attacher/OpenJ9VirtualMachine.java
Outdated
Show resolved
Hide resolved
theresa-m
force-pushed
the
securitymanager_4
branch
from
a0cbf2a to
60f2c43
Compare
keithc-ca
requested changes
Jan 31, 2025
jcl/src/jdk.management/share/classes/com/ibm/lang/management/ThreadMXBean.java
Outdated
Show resolved
Hide resolved
theresa-m
force-pushed
the
securitymanager_4
branch
4 times, most recently
from
2eb811a to
3c32682
Compare
keithc-ca
reviewed
Jan 31, 2025
| try { | ||
| jniaaTmp = SharedSecrets.class.getDeclaredField("javaNetInetAddressAccess"); //$NON-NLS-1$ | ||
| jniaaTmp.setAccessible(true); | ||
| } catch (NoSuchFieldException | SecurityException e) { | ||
| // ignore exceptions | ||
| jniaaTmp = null; |
There was a problem hiding this comment.
This is redundant. The suggestion was to put this in the Java24+ catch block (after line 959), without which, Java 24+ will not compile.
This pull requests is the first of two prs to remove the use of java.security.AccessController.doPrivileged in JDK 24. It also removes a few cases of System.getSystemProperty and SecurityException mentions that were previously missed. Signed-off-by: Theresa Mammarella <[email protected]>
theresa-m
force-pushed
the
securitymanager_4
branch
from
3c32682 to
11af434
Compare
|
Jenkins test sanity amac jdk21,jdk24 |
keithc-ca
approved these changes
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests is the first of two prs to remove the use of java.security.AccessController.doPrivileged in JDK 24. It also removes a few cases of System.getSystemProperty and SecurityException mentions that were previously missed.
21 and 24 sanity https://hyc-runtimes-jenkins.swg-devops.com/view/OpenJ9%20-%20Personal/job/Pipeline-Build-Test-Personal/26116/
24 extended https://hyc-runtimes-jenkins.swg-devops.com/view/Test_grinder/job/Grinder/47217/
Related: #20563