1.2.3 Release #50
Merged
1.2.3 Release #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The whiteboard implementation must create dynamic classes for each extension service to allow multiple instances of the same class to be registered. The existing generics handling was limited, and could not correctly represent unbound type variables, wildcards, nested generics, or reification of variables declared in super types. This commit enhances the generics processing in an attempt to cover all cases. Fixes #39 Signed-off-by: Tim Ward <[email protected]>
Fix issues with generics in extension services
I identified a missing test case where a Type Variable changes name in the generics declaration of an intermediate super class, and also where the Type Variable use is nested inside another generic declaration. Once added these tests showed up some further weaknesses which I have attempted to fix by establishing a context mapping of contract interface to implementing type and type to super type. This constrains the search through the type information and ensures that we only match type information that is relevant in the current context. Signed-off-by: Tim Ward <[email protected]>
Signed-off-by: Tim Ward <[email protected]>
Further work on Generics support
- removed unused dependency Thanks for reporting! Signed-off-by: Mark Hoffmann <[email protected]>
- removed unnused imports - removed other warnings Signed-off-by: Mark Hoffmann <[email protected]>
fixes #46 Signed-off-by: Juergen Albert <[email protected]>
whiteboard servlet runtime now forwards all properties
Some generic mappings were creating partially valid signatures which terminated early, losing generics information for additional contracts. These tests and fix ensure that the signature is generated correctly Signed-off-by: Tim Ward <[email protected]>
[generics] Fix broken signatures in proxy classes
Signed-off-by: Juergen Albert <[email protected]>
The latest commit removed some tests which need to be restored. It also made some visitor usage inconsistent, so we now respect the return value of visitTypeParameter everywhere Signed-off-by: Tim Ward <[email protected]>
[generics] Restore deleted tests and improve consistency of access
Signed-off-by: Juergen Albert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.