-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autopaho managePublishQueue() does not call Remove, Quarantine, or Leave if Reader() fails #233
Comments
Well spotted; happy to accept a PR. I'm not not sure if it's best to leave or Remove in this case; if we cannot read the message then what are the chances that this would succeed if we try again. |
This is the case that prompted me to open #234 |
Just noticed a further bug here; we check |
That seems reasonable. I also think we should have that same timeout in the |
In autopaho, if
entry.Reader()
fails we do not callRemove
,Quarantine
, orLeave
on the entry as required. I'm guessing there should be a call toLeave()
in the case whereReader()
fails. Happy to open a PR for this.https://github.com/eclipse/paho.golang/blob/ef0065fea247d5fb388fa82390cedce694e844e1/autopaho/auto.go#L553-L562
The text was updated successfully, but these errors were encountered: