Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove org.osgi.service.http and felix.http.servlet-api from SDK TP #1677

Merged

Conversation

HannesWell
Copy link
Member

With eclipse-equinox/equinox#403 the sources of org.osgi.service.http are provided in a re-packed bundle from Equinox, that also provides the OSGi capabilities which where temporarily provided by felix.http.servlet-api.

As planned, this also reverts #1672 because it is not necessary anymore.

With eclipse-equinox/equinox#403 the sources of
org.osgi.service.http are provided in a re-packed bundle from Equinox,
that also provides the OSGi capabilities which were temporarily
provided by felix.http.servlet-api.
@HannesWell
Copy link
Member Author

Build is green and looking at the build's console output I can see no [WARNING] Problems resolving provisioning plan regarding the osgi packages or bundles. So this is good to go.

@HannesWell HannesWell merged commit 839ec72 into eclipse-platform:master Dec 18, 2023
3 of 4 checks passed
@HannesWell HannesWell deleted the remove-osgi-service-http branch December 18, 2023 22:10
@akurtakov
Copy link
Member

@HannesWell Would you please adjust javadocs build ? They are broken now https://download.eclipse.org/eclipse/downloads/drops4/I20231218-1800/compilelogs/platform.doc.isv.javadoc.txt . If/when #1533 is finished failing javadocs should fail the build so issues like this one should be uncovered earlier.

@laeubi
Copy link
Contributor

laeubi commented Dec 19, 2023

@HannesWell I suspect that the platform build now fails de to these changes as well:
https://ci.eclipse.org/platform/job/eclipse.platform/job/master/

it complains about

Failed to execute goal org.eclipse.tycho:tycho-p2-director-plugin:4.0.5-SNAPSHOT:materialize-products (create-distributions) on project infocenter-product: Installation of product infocenter for environment linux/gtk/x86_64 failed

@HannesWell
Copy link
Member Author

it complains about

Failed to execute goal org.eclipse.tycho:tycho-p2-director-plugin:4.0.5-SNAPSHOT:materialize-products (create-distributions) on project infocenter-product: Installation of product infocenter for environment linux/gtk/x86_64 failed

I think this is more an issue of the replacement of embedded sources itself, but I'm not entirely sure.
Created eclipse-platform/eclipse.platform#1054, which at least fixed my local build (without tests).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants