Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Java 21 the primary JVM to execute the maven build #1919

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

laeubi
Copy link
Contributor

@laeubi laeubi commented Mar 20, 2024

Java 21 is the next LTS and projects are allowed to use Java 21 in this release, therefore it should become the new primary Java version used to execute the build.

This also will allow us to catch any possible issues with Java 21 used as build VM.

@laeubi laeubi requested a review from akurtakov March 20, 2024 06:44
Java 21 is the next LTS and projects are allowed to use Java 21 in this
release, therefore it should become the new primary Java version used to
execute the build.

This also will allow us to catch any possible issues with Java 21 used
as build VM.
@akurtakov
Copy link
Member

Rebased to see whether the failuse is random one or a general one to be investigated.

@akurtakov akurtakov merged commit e7f3eb0 into eclipse-platform:master Mar 22, 2024
4 checks passed
@merks
Copy link
Contributor

merks commented Mar 25, 2024

@akurtakov @laeubi

I think this need to be reverted. All builds fail since this change:

https://ci.eclipse.org/platform/job/eclipse.platform.releng.aggregator/job/master/

The build will continue to fail until JDT addresses this issue:

eclipse-jdt/eclipse.jdt.core#2217

Okay?

@laeubi
Copy link
Contributor Author

laeubi commented Mar 25, 2024

Why not wait "until JDT addresses this issue" it look easy enough to fix instead of reverting, also I think not all builds fail, maybe aggregator builds and JDT builds but not pde, platform(ui), equinox, p2 and so on...

Especially as the intend of this is

This also will allow us to catch any possible issues with Java 21 used as build VM.

so issues discovered should be fixed instead of making them invisible :-)

@merks
Copy link
Contributor

merks commented Mar 25, 2024

Because:

  1. No verification build works right now so nothing else can be verified.
  2. Until JDT is fixed, it will simply keep telling us about the same problem over and over.

I.e., the change has bought the only value it can bring right now with the ongoing result that the build itself provides no value for the purpose for which it was designed, which is to verify changes.

@akurtakov
Copy link
Member

eclipse-jdt/eclipse.jdt.core#2214 should fix the issue. Assuming it finishes without issues today I'll merge it and we should move on. Please give it some time for issues to be fixed.

@merks
Copy link
Contributor

merks commented Mar 25, 2024

I know how the work around the problem so it's not urgent from that perspective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants