Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[I-build] Fix I-build kubernetes container configuration #2108

Merged

Conversation

HannesWell
Copy link
Member

Ensure all stages run within the 'jnlp' container and remove defaultContainer 'container' because a container named 'container' isn't defined.

See #2101 (comment)

Ensure all stages run within the 'jnlp' container and remove
defaultContainer 'container' because a container named 'container' isn't
defined.

See eclipse-platform#2101 (comment)

Co-authored-by: Sébastien Heurtematte <[email protected]>
@HannesWell
Copy link
Member Author

From #2107 (comment)

With all that my current guess is that running it in the jnlp might have fixed the triggering, but using another image could have broke test execution, because the previous image defined a lot more volumes etc.? I have no clue if the default centos-8 does that too?
As another test I have now replayed build 3 (which has the config before your change) but removed the defaultContainer 'container' and added the container('jnlp') explicitly for the Trigger tests and the Trigger publication to Maven snapshots repo explicitly (remove the default should have the same effect):
https://ci.eclipse.org/releng/job/Builds/job/I-build-4.33/5/

The build completed successfully and triggered the test jobs also with the buildId parameters as expected. This PR records the changes applied to that replayed job. But since this is a manually triggered build and they succeeded in the past I'm not absolutely sure this will fix #2101 and to confirm it we would have to await a cron-triggered build. But at least from my current understanding this is what I assume the best guess.

@HannesWell
Copy link
Member Author

I'm about to submit this now and await tonight's I-build result to see if this already fixes #2101 or at least if the missing parameters don't happen again.
#2107 still contains the full change applied manually before.

@HannesWell HannesWell merged commit ffb63bd into eclipse-platform:master Jun 7, 2024
2 of 3 checks passed
@HannesWell HannesWell deleted the fix-iBuild-container-minimal branch June 7, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant