-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provide junit ScreenshotOnFailure TestWatcher #2368
Conversation
May this be better placed in |
Probably even better place is https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/tree/master/eclipse.platform.releng/bundles/org.eclipse.test . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move to org.eclipse.test bundle.
Moving it would be a hell of work. Moving the class would be an API breakage. TracingSuite requires it needs to be fixed, Access restrictions need to be fixed... . I don't like how it is either, but to clean up that mess seems too complicated :-( |
Tests are not API incl org.eclipse.test. Does it make the task easier? |
technically they are API. Some tests just do not include org.eclipse.test but the performance one. so no it's not helpful. |
Everything should be in o.e.test without any breakage so you can patch Screenshots in o.e.test bundle. |
Tests in I-build seems to be in good shape now. |
3baa2f3
to
0f14f20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now.
Not only seems that build error unrelated but should'nt it have produced an automated version bump @HannesWell ? |
It is caused by #2392 |
The version-increment workflow is not (yet) setup for this repository. In the current form it would be basically the same as the verification build. I plan to work on a Tycho mojo that should speed that up significantly but in the meantime I think it's not worth the effort to enable it in this repo. |
0f14f20
to
c16f6cf
Compare
c16f6cf
to
93ba9bd
Compare
No description provided.