[WIP] [StickyScrolling] Add extension point for sticky lines provider #2398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Christopher-Hermann
added a commit
to Christopher-Hermann/eclipse.platform.ui
that referenced
this pull request
Oct 14, 2024
Move sticky lines adaptation to the growing sticky lines control into the central sticky scrolling handler. This change simplifies the sticky lines provider, making implementations for specific languages more straightforward and maintainable. Preparation for eclipse-platform#2398
Christopher-Hermann
added a commit
to Christopher-Hermann/eclipse.platform.ui
that referenced
this pull request
Oct 14, 2024
Move sticky lines adaptation to the growing sticky lines control into the central sticky scrolling handler. This change simplifies the sticky lines provider, making implementations for specific languages more straightforward and maintainable. Preparation for eclipse-platform#2398
BeckerWdf
pushed a commit
to Christopher-Hermann/eclipse.platform.ui
that referenced
this pull request
Oct 15, 2024
Move sticky lines adaptation to the growing sticky lines control into the central sticky scrolling handler. This change simplifies the sticky lines provider, making implementations for specific languages more straightforward and maintainable. Preparation for eclipse-platform#2398
In order to implement editor/language specific sticky lines provider, a new extension point is introduced.
Christopher-Hermann
force-pushed
the
stickyScrollingEnhancementPoint
branch
from
8139ade
to
a3c3ead
Compare
Christopher-Hermann
added a commit
to Christopher-Hermann/eclipse.platform.ui
that referenced
this pull request
Oct 15, 2024
Move sticky lines adaptation to the growing sticky lines control into the central sticky scrolling handler. This change simplifies the sticky lines provider, making implementations for specific languages more straightforward and maintainable. Preparation for eclipse-platform#2398
Christopher-Hermann
added a commit
to Christopher-Hermann/eclipse.platform.ui
that referenced
this pull request
Oct 15, 2024
Move sticky lines adaptation to the growing sticky lines control into the central sticky scrolling handler. This change simplifies the sticky lines provider, making implementations for specific languages more straightforward and maintainable. Preparation for eclipse-platform#2398
Christopher-Hermann
added a commit
to Christopher-Hermann/eclipse.platform.ui
that referenced
this pull request
Oct 16, 2024
Move sticky lines adaptation to the growing sticky lines control into the central sticky scrolling handler. This change simplifies the sticky lines provider, making implementations for specific languages more straightforward and maintainable. Preparation for eclipse-platform#2398
Christopher-Hermann
added a commit
to Christopher-Hermann/eclipse.platform.ui
that referenced
this pull request
Oct 16, 2024
Move sticky lines adaptation to the growing sticky lines control into the central sticky scrolling handler. This change simplifies the sticky lines provider, making implementations for specific languages more straightforward and maintainable. Preparation for eclipse-platform#2398
Christopher-Hermann
added a commit
to Christopher-Hermann/eclipse.platform.ui
that referenced
this pull request
Oct 17, 2024
Move the text and style calculation to the StickyLine itself in order to enable the sticky line provider to overwrite the default behavior. This is needed to apply custom texts or custom styles for the sticky lines. Preparation for eclipse-platform#2398
Christopher-Hermann
added a commit
that referenced
this pull request
Oct 25, 2024
Move sticky lines adaptation to the growing sticky lines control into the central sticky scrolling handler. This change simplifies the sticky lines provider, making implementations for specific languages more straightforward and maintainable. Preparation for #2398
Christopher-Hermann
added a commit
to Christopher-Hermann/eclipse.platform.ui
that referenced
this pull request
Oct 25, 2024
Move the text and style calculation to the StickyLine itself in order to enable the sticky line provider to overwrite the default behavior. This is needed to apply custom texts or custom styles for the sticky lines. Preparation for eclipse-platform#2398
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First version of the extension points for sticky lines provider. Via the extension point it's possible to register an own provider for a editor instance.
There is some refactoring needed which will be done on separate PR.
This PR will be merged after the implementation of an initial proof-of-concept provider for Java, and potentially ABAP as well, to ensure a stable API.