Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean-up and simplify E4 ModelAssembler #2427

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Clean-up and simplify E4 ModelAssembler #2427

wants to merge 1 commit into from

Conversation

HannesWell
Copy link
Member

@fipro78 do you want to review this?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 19, 2024 •
edited
Loading

Test Results

 1 818 files  + 19   1 818 suites  +19   1h 43m 36s ⏱️ - 5m 28s
 7 711 tests ±  0   7 483 ✅ ±  0  228 💤 ±0  0 ❌ ±0 
24 294 runs  +359  23 547 ✅ +353  747 💤 +6  0 ❌ ±0 

Results for commit b15598d. ± Comparison against base commit 2945d5b.

♻️ This comment has been updated with latest results.

fipro78
fipro78 approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@fipro78 fipro78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fipro78 fipro78 fipro78 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HannesWell @fipro78