-
Notifications
You must be signed in to change notification settings - Fork 110
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Improve array length assertions in resource tests
In order to reduce/avoid usage of ambiguous `assertEquals` (hard to distinguish expected/actual) and prepare for a migration to JUnit 5 with swapped expected/actual parameters in the `assertEquals` signature, this change replaces certain `assertEquals` calls with AssertJ assertions: * Replace `assertEquals(MESSAGE, EXPECTED, ACTUAL.length)` with `assertThat(ACTUAL).as(MESSAGE).hasSize(EXPECTED))` and remove obsolete message where possible * Replace `assertEquals(EXPECTED, ACTUAL.length)` with `assertThat(ACTUAL).hasSize(EXPECTED)) * Replace `hasSize(0)` with `isEmpty()` to improve failure messages * Combine array size comparison with array contents comparison where possible
- Loading branch information
1 parent
77f6f06
commit 6a574c3
Showing
50 changed files
with
1,276 additions
and
1,594 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.