Fix recorder script #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The run_recorderFMS.sh script has been changed to only subscribe to the (very limited) list of paths that are actually used by the FMS-Forwarder component. A new recording has been created which no longer contains values that are outside of the signal's specified [min, max] range. Fixes eclipse-sdv-blueprints#17
eriksven
reviewed
Oct 24, 2023
| @@ -1,18 +0,0 @@ | |||
| # SPDX-FileCopyrightText: 2023 Contributors to the Eclipse Foundation | |||
There was a problem hiding this comment.
Should we add such a license file (signalsFmsRecording.csv.license) to the CSV file because the CSV-file cannot contain comment fields for a potential header?
There was a problem hiding this comment.
It should already be in the code base ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The run_recorderFMS.sh script has been changed to only subscribe
to the (very limited) list of paths that are actually used by the
FMS-Forwarder component.
A new recording has been created which no longer contains values
that are outside of the signal's specified [min, max] range.
Fixes #17