Fix linter errors #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the client ID from the MqttConnection struct which is only used during connection establishment.
|
Currently, there are further linter errors found by the "Lint source code" action. Should we remove them as well as part of this PR? |
Closed
Updated minimum version of protobuf crate to fix clippy warning. See stepancheg/rust-protobuf#733
sophokles73
force-pushed
the
fix_linter_errors
branch
from
869ca3e
to
dd33c56
Compare
|
@eriksven can you take another look? |
|
LGTM |
eriksven
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.