Include license report in container images #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The license files only required when (re-)distributing code in binary or source form, which we do not do.
Extended the Dockerfiles to generate a license report for the 3rd party dependencies being used and to include the report in the container image being produced.
|
@eriksven would you mind taking a look? |
|
I am already on it. Looks good so far. |
eriksven
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended the Dockerfiles to generate a license report for the 3rd party
dependencies being used and to include the report in the container
image being produced.
Also removed the 3rd party license files from the repository itself because they only need to be included when distributing copies of the 3rd party code in source or binary form. The license text files are determined dynamically as part of building the docker images.