[4323] Improve palette style #4324
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
mcharfadi
force-pushed
the
mch/enh/palette-style
branch
3 times, most recently
from
5ddb9a2 to
cacfbc1
Compare
Bug: #4285 Signed-off-by: Michaël Charfadi <[email protected]>
mcharfadi
force-pushed
the
mch/enh/palette-style
branch
from
cacfbc1 to
fea2236
Compare
Bug: #4323 Signed-off-by: Michaël Charfadi <[email protected]>
mcharfadi
force-pushed
the
mch/enh/palette-style
branch
from
fea2236 to
2a9ca7f
Compare
sbegaudeau
requested changes
Feb 10, 2025
| @@ -41,7 +41,7 @@ export const useDiagramDirectEdit = (): UseDiagramDirectEditValue => { | |||
| if (key !== 'F2' && isTextField) { | |||
| return; | |||
| } | |||
|
|
|||
| event.preventDefault(); | |||
There was a problem hiding this comment.
How is that related to styling? What is the impact of this change?
| @@ -138,36 +145,32 @@ export const Palette = ({ | |||
|
|
|||
| const { hideDiagramPalette } = useDiagramPalette(); | |||
| const { hideDiagramElementPalette } = useDiagramElementPalette(); | |||
| const { hideGroupPalette } = useGroupPalette(); | |||
There was a problem hiding this comment.
Why is this one removed from here? I'm not sure why it got added in the first place
Comment on lines
+78
to
+82
| const closeAllPalettes = useCallback(() => { | ||
| hideDiagramPalette(); | ||
| hideDiagramElementPalette(); | ||
| hideGroupPalette(); | ||
| }, [hideDiagramPalette, hideDiagramElementPalette, hideGroupPalette]); |
There was a problem hiding this comment.
- Why does the diagram panel has to take all this new coupling?
- How is that related to styling at all?
There was a problem hiding this comment.
One request was to hide the palette when executing a tool from the panel.
Some tools open model that can hide the palette
|
I'm closing the PR because it has been divided in smaller ones |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request template
General purpose
What is the main goal of this pull request?
Project management
priority:andpr:labels been added to the pull request? (In case of doubt, start with the labelspriority: lowandpr: to review later)area:,difficulty:,type:)CHANGELOG.adocbeen updated to reference the relevant issues?CHANGELOG.adoc? (Including changes in the GraphQL API)CHANGELOG.adoc? For example indoc/screenshots/2022.5.0-my-new-feature.pngArchitectural decision records (ADR)
[doc]?CHANGELOG.adoc?Dependencies
CHANGELOG.adoc?CHANGELOG.adoc?Frontend
This section is not relevant if your contribution does not come with changes to the frontend.
General purpose
Typing
We need to improve the typing of our code, as such, we require every contribution to come with proper TypeScript typing for both changes contributing new files and those modifying existing files.
Please ensure that the following statements are true for each file created or modified (this may require you to improve code outside of your contribution).
useMutation<DATA_TYPE, VARIABLE_TYPE>(…)useQuery<DATA_TYPE, VARIABLE_TYPE>(…)useSubscription<DATA_TYPE, VARIABLE_TYPE>(…)useMachine<CONTEXT_TYPE, EVENTS_TYPE>(…)useState<STATE_TYPE>(…)?.(if the GraphQL API specifies that a field cannot benull, do not treat it has potentiallynullfor example)let diagram: Diagram | null = null;)Backend
This section is not relevant if your contribution does not come with changes to the backend.
General purpose
Architecture
Review
How to test this PR?
Please describe here the various use cases to test this pull request