[4383] Add support for representation duplication #4384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug: #3740 Signed-off-by: Laurent Fasani <[email protected]> Signed-off-by: Florian ROUËNÉ <[email protected]>
Bug: #3740 Signed-off-by: Laurent Fasani <[email protected]> Signed-off-by: Florian ROUËNÉ <[email protected]>
frouene
changed the title
Bug: #4383 Signed-off-by: Florian ROUËNÉ <[email protected]>
frouene
force-pushed
the
fro/enh/duplicate-representation
branch
from
11b9ab0 to
7dca70e
Compare
gcoutable
requested changes
Jan 27, 2025
| public class DuplicateRepresentationEventHandler implements IEditingContextEventHandler { | ||
|
|
||
| private static final String NEW_REPRESENTATION_METADATA = "newRepresentationMetadata"; | ||
| private static final String COPY_SUFFIX = "_copy"; |
Comment on lines
+11
to
+15
| type DuplicateRepresentationSuccessPayload { | ||
| id: ID! | ||
| representationMetadata: RepresentationMetadata | ||
| messages: [Message]! | ||
| } |
There was a problem hiding this comment.
No need for a specific success payload...
| messages: [Message]! | ||
| } | ||
|
|
||
| union DuplicateRepresentationPayload = ErrorPayload | DuplicateRepresentationSuccessPayload |
Comment on lines
+34
to
+40
| ... on DuplicateRepresentationSuccessPayload { | ||
| representationMetadata { | ||
| id | ||
| label | ||
| kind | ||
| } | ||
| } |
There was a problem hiding this comment.
Next explorer refresh will return the duplicated representation
Comment on lines
+64
to
+65
| @Sql(scripts = {"/scripts/papaya.sql"}, executionPhase = Sql.ExecutionPhase.BEFORE_TEST_METHOD) | ||
| @Sql(scripts = {"/scripts/cleanup.sql"}, executionPhase = Sql.ExecutionPhase.AFTER_TEST_METHOD, config = @SqlConfig(transactionMode = SqlConfig.TransactionMode.ISOLATED)) |
|
|
||
| useEffect(() => { | ||
| if (duplicatedRepresentationMetadata) { | ||
| setSelection({ entries: [duplicatedRepresentationMetadata] }); |
There was a problem hiding this comment.
You are putting something in the selection that may not exist yet?
The payload for the explorer subscription may not have been refreshed yet.
I am not sure if we want this.
| >(duplicateRepresentationMutation); | ||
| useReporting(mutationDuplicateRepresentationResult, (data: GQLDuplicateRepresentationData) => { | ||
| const payload = data.duplicateRepresentation; | ||
| if (payload.__typename === 'DuplicateRepresentationSuccessPayload') { |
There was a problem hiding this comment.
No need for the specific success payload
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request template
General purpose
What is the main goal of this pull request?
Project management
priority:andpr:labels been added to the pull request? (In case of doubt, start with the labelspriority: lowandpr: to review later)area:,difficulty:,type:)CHANGELOG.adocbeen updated to reference the relevant issues?CHANGELOG.adoc? (Including changes in the GraphQL API)CHANGELOG.adoc? For example indoc/screenshots/2022.5.0-my-new-feature.pngArchitectural decision records (ADR)
[doc]?CHANGELOG.adoc?Dependencies
CHANGELOG.adoc?CHANGELOG.adoc?Frontend
This section is not relevant if your contribution does not come with changes to the frontend.
General purpose
Typing
We need to improve the typing of our code, as such, we require every contribution to come with proper TypeScript typing for both changes contributing new files and those modifying existing files.
Please ensure that the following statements are true for each file created or modified (this may require you to improve code outside of your contribution).
useMutation<DATA_TYPE, VARIABLE_TYPE>(…)useQuery<DATA_TYPE, VARIABLE_TYPE>(…)useSubscription<DATA_TYPE, VARIABLE_TYPE>(…)useMachine<CONTEXT_TYPE, EVENTS_TYPE>(…)useState<STATE_TYPE>(…)?.(if the GraphQL API specifies that a field cannot benull, do not treat it has potentiallynullfor example)let diagram: Diagram | null = null;)Backend
This section is not relevant if your contribution does not come with changes to the backend.
General purpose
Architecture
Review
How to test this PR?
Please describe here the various use cases to test this pull request