feat(importCDX): Add functionality to configure release creation when importing SBOM to an existing project #2458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sameed20
force-pushed
the
feat/enable-users-to-configure-release-creation-on-importing-SBOM-on-an-existing-project-2435
branch
from
72f9853
to
0c94fe8
Compare
|
Testing this PR. |
afsahsyeda
added
needs code review
needs general test
|
@sameed20 The REST API docs have not been updated. Pls update the docs for this endpoint as well |
sameed20
force-pushed
the
feat/enable-users-to-configure-release-creation-on-importing-SBOM-on-an-existing-project-2435
branch
from
0c94fe8
to
6d622d7
Compare
|
@sameed20 Feature is working as expected if the component has a VCS field in the SBOM for both orphan and non-orphan pkgs. But if an orphan pkg is present in the project and the SBOM also has different version of the orphan pkg then the it is simply adding the orphan pkgs and never replacing it. Same behaviour is seen when imported from UI or rest. |
sameed20
force-pushed
the
feat/enable-users-to-configure-release-creation-on-importing-SBOM-on-an-existing-project-2435
branch
from
6d622d7
to
2fa92ee
Compare
sameed20
force-pushed
the
feat/enable-users-to-configure-release-creation-on-importing-SBOM-on-an-existing-project-2435
branch
2 times, most recently
from
6b2e89f
to
c9aa23f
Compare
afsahsyeda
requested changes
Jun 25, 2024
backend/src-common/src/main/java/org/eclipse/sw360/cyclonedx/CycloneDxBOMImporter.java
Outdated
Show resolved
Hide resolved
backend/src-common/src/main/java/org/eclipse/sw360/cyclonedx/CycloneDxBOMImporter.java
Outdated
Show resolved
Hide resolved
backend/src-common/src/main/java/org/eclipse/sw360/cyclonedx/CycloneDxBOMImporter.java
Outdated
Show resolved
Hide resolved
backend/src-common/src/main/java/org/eclipse/sw360/cyclonedx/CycloneDxBOMImporter.java
Outdated
Show resolved
Hide resolved
backend/src-common/src/main/java/org/eclipse/sw360/cyclonedx/CycloneDxBOMImporter.java
Outdated
Show resolved
Hide resolved
backend/src-common/src/main/java/org/eclipse/sw360/datahandler/db/ProjectDatabaseHandler.java
Outdated
Show resolved
Hide resolved
sameed20
force-pushed
the
feat/enable-users-to-configure-release-creation-on-importing-SBOM-on-an-existing-project-2435
branch
from
c9aa23f
to
c5311b1
Compare
afsahsyeda
reviewed
Jun 26, 2024
backend/src-common/src/main/java/org/eclipse/sw360/cyclonedx/CycloneDxBOMImporter.java
Outdated
Show resolved
Hide resolved
sameed20
force-pushed
the
feat/enable-users-to-configure-release-creation-on-importing-SBOM-on-an-existing-project-2435
branch
from
c5311b1
to
9f45c16
Compare
sameed20
force-pushed
the
feat/enable-users-to-configure-release-creation-on-importing-SBOM-on-an-existing-project-2435
branch
from
9f45c16
to
b2664f4
Compare
sameed20
force-pushed
the
feat/enable-users-to-configure-release-creation-on-importing-SBOM-on-an-existing-project-2435
branch
from
b2664f4
to
8014c8b
Compare
sameed20
requested review from
heliocastro,
GMishx,
KoukiHama,
arunazhakesan and
ag4ums
as code owners
sameed20
force-pushed
the
feat/enable-users-to-configure-release-creation-on-importing-SBOM-on-an-existing-project-2435
branch
2 times, most recently
from
aae1f13
to
abc1735
Compare
|
@afsahsyeda I see most change requests have been closed. Can you please review it again? |
sameed20
force-pushed
the
feat/enable-users-to-configure-release-creation-on-importing-SBOM-on-an-existing-project-2435
branch
4 times, most recently
from
cf30a84
to
2fe51fc
Compare
sameed20
force-pushed
the
feat/enable-users-to-configure-release-creation-on-importing-SBOM-on-an-existing-project-2435
branch
from
2fe51fc
to
695ce84
Compare
afsahsyeda
requested changes
Oct 30, 2024
backend/common/src/main/java/org/eclipse/sw360/datahandler/db/ProjectDatabaseHandler.java
Outdated
Show resolved
Hide resolved
|
Testing successful. |
sameed20
force-pushed
the
feat/enable-users-to-configure-release-creation-on-importing-SBOM-on-an-existing-project-2435
branch
4 times, most recently
from
aaf0ed3
to
f779674
Compare
GMishx
removed
the
needs general test
GMishx
requested changes
Nov 5, 2024
| @@ -2064,7 +2064,8 @@ public ResponseEntity<?> importSBOMonProject( | |||
| @Parameter(description = "Project ID", example = "376576") | |||
| @PathVariable(value = "id", required = true) String id, | |||
| @Parameter(description = "SBOM file") | |||
| @RequestBody MultipartFile file | |||
| @RequestBody MultipartFile file, | |||
| @RequestParam(value = "doNotReplacePackageAndRelease", required = false) boolean doNotReplacePackageAndRelease | |||
There was a problem hiding this comment.
Please add OpenAPI doc for the parameter with @Parameter annotation.
There was a problem hiding this comment.
@GMishx I have made the asked change. Please review.
There was a problem hiding this comment.
Would recommend a simpler description like "Overwrite existing project releases and packages while importing new SBOM?"
There was a problem hiding this comment.
@GMishx Please review.
sameed20
force-pushed
the
feat/enable-users-to-configure-release-creation-on-importing-SBOM-on-an-existing-project-2435
branch
from
f779674
to
4c8b60f
Compare
… importing SBOM to an existing project Signed-off-by: sameed.ahmad <[email protected]>
sameed20
force-pushed
the
feat/enable-users-to-configure-release-creation-on-importing-SBOM-on-an-existing-project-2435
branch
from
4c8b60f
to
7900e92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the feature that allows users to configure release creation when importing CycloneDX SBOM to an existing project.
closes: #2435