fix(rest) : modified attachment info in response to the moderation request rest api #2498
Conversation
keerthi-bl
force-pushed
the
fix/getAttachmentsInModReqEndPoint
branch
2 times, most recently
from
9a986d0
to
9c63726
Compare
|
Resolve the merge conflicts |
...ava/org/eclipse/sw360/rest/resourceserver/moderationrequest/ModerationRequestController.java
Outdated
Show resolved
Hide resolved
...ava/org/eclipse/sw360/rest/resourceserver/moderationrequest/ModerationRequestController.java
Outdated
Show resolved
Hide resolved
keerthi-bl
force-pushed
the
fix/getAttachmentsInModReqEndPoint
branch
from
9c63726
to
c8fb304
Compare
keerthi-bl
requested review from
heliocastro,
KoukiHama,
arunazhakesan and
ag4ums
as code owners
keerthi-bl
force-pushed
the
fix/getAttachmentsInModReqEndPoint
branch
from
c8fb304
to
bcddf76
Compare
GMishx
added
needs code review
needs general test
|
@rudra-superrr please test this branch. @smrutis1 please help review it. |
|
Testing was successful. |
|
One thing that I have found is, when a user updates a project then MR is created but if the same user updates some other field of the same project then it overwrites the previous moderation request. |
GMishx
removed
the
needs general test
Can you please open an issue for the same? We need to rework on the Moderation Request with REST API. With the Liferay UI, we had the liberty to check when an MR will be created and how to treat it. But with REST API, currently there is no way to check the same and we have to revert to this behavior. Please check #2405 (comment) as well. |
But this issue is happening because of the changes made in this PR. |
Closes : #2497
Description
Please describe your issue in few words here.
How to reproduce
Describe the bug and list the steps you used when the issue occurred.
Screenshots ( if applicable )