feat(rest): Add size parameter to clearing request. #2642
+104
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshitjoshii
requested review from
heliocastro,
GMishx,
KoukiHama,
arunazhakesan and
ag4ums
as code owners
akshitjoshii
added
needs code review
needs general test
akshitjoshii
force-pushed
the
feat/add-size-field-cr-endpoints
branch
from
72fc0f3
to
7a056d3
Compare
|
Testing this PR. |
akshitjoshii
force-pushed
the
feat/add-size-field-cr-endpoints
branch
3 times, most recently
from
8103c82
to
1916a1b
Compare
|
@akshitjoshii When increasing the number of releases in a project, the size of the CR should increase accordingly. However, I observed that when fetching a CR by ID from an endpoint, the size parameter in the response does not reflect the updated size value, even though the size field in the database updates as expected. |
akshitjoshii
force-pushed
the
feat/add-size-field-cr-endpoints
branch
2 times, most recently
from
5010d20
to
7d441e0
Compare
|
@sameed20 , made the changes. Pls check |
|
Test successful. |
akshitjoshii
removed
the
needs general test
afsahsyeda
requested changes
Nov 5, 2024
.../java/org/eclipse/sw360/rest/resourceserver/clearingrequest/Sw360ClearingRequestService.java
Outdated
Show resolved
Hide resolved
akshitjoshii
force-pushed
the
feat/add-size-field-cr-endpoints
branch
2 times, most recently
from
5a71bae
to
76dbdc3
Compare
GMishx
reviewed
Nov 8, 2024
...ce-server/src/main/java/org/eclipse/sw360/rest/resourceserver/core/RestControllerHelper.java
Outdated
Show resolved
Hide resolved
akshitjoshii
force-pushed
the
feat/add-size-field-cr-endpoints
branch
from
76dbdc3
to
8c8f4cb
Compare
|
@afsahsyeda can you please review the changes for auto merge of this branch? |
Signed-off-by: Akshit Joshi <[email protected]>
akshitjoshii
force-pushed
the
feat/add-size-field-cr-endpoints
branch
from
8c8f4cb
to
46288b2
Compare
afsahsyeda
approved these changes
Nov 18, 2024
heliocastro
approved these changes
Nov 19, 2024
| import org.eclipse.sw360.datahandler.thrift.RemoveModeratorRequestStatus; | ||
| import org.eclipse.sw360.datahandler.thrift.RequestStatus; | ||
| import org.eclipse.sw360.datahandler.thrift.SW360Exception; | ||
| import org.eclipse.sw360.datahandler.thrift.*; |
There was a problem hiding this comment.
In the future, remember that best practices is no do global imports.
|
@akshitjoshii Please resolve the merge conflict and if possible revert the glob on imports. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new field size to the clearing request which determines the size of the clearing request based on the number of open releases in the project for which the CR is created.
Size based on the table below :
1- 20 = Very Small
21- 50 = Small
50-75 = Medium
75-150 = Large
150 and above = Very large
The CR size should be dynamic. if release are uploaded after CR creation, it should reflect in the
CR Size.