Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set correct npm version, use latest vscode extension versions #463

Merged
merged 4 commits into from
Oct 20, 2023

Conversation

danieldietrich
Copy link
Contributor

@danieldietrich danieldietrich commented Oct 18, 2023

Avoid #449 when using Gitpod by setting node version v14 aka lts/fermium (currently npm version 6.14.18)

@planger however ... I understand that it does not really fix the original issue of supporting newer node/npm versions. this is just a quick fix to be able to contribute to the current site

@planger planger self-requested a review October 20, 2023 14:40
Copy link
Contributor

@planger planger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @danieldietrich! This change looks good to me and I'm happy to approve!

However, I think we should keep #449 to track the task of supporting more current node versions.
Also, I think we should mention in the readme that building locally requires node 14.x.

Thank you!

@danieldietrich
Copy link
Contributor Author

Thank you for the quick reply @planger!

(...) we should keep #449 to track the task of supporting more current node versions.

That makes absolutely sense to me!

(...) we should mention in the readme that building locally requires node 14.x

Yep, I've missed that. I've added another commit.
Please let me know if something needs to be changed or rephrased.

Thank you Philip & have a nice weekend

@danieldietrich
Copy link
Contributor Author

@planger I recognized that the package-lock.json changed in my GitPod workspace. Do you always commit it? In that case I would add another commit before this PR is merged. Thanks!

Copy link
Contributor

@planger planger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the fast turnaround! I just made a suggestion to mention that ignoring peer dependency conflicts works too.

I think it would make sense to commit the modified package-lock.json. Thank you!

README.md Outdated Show resolved Hide resolved
@danieldietrich
Copy link
Contributor Author

Great! All changes are in place now.

@planger planger merged commit 971d86a into eclipse-theia:master Oct 20, 2023
5 checks passed
@danieldietrich danieldietrich deleted the dd/gitpod-yml-fix branch October 20, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants