-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set correct npm version, use latest vscode extension versions #463
Set correct npm version, use latest vscode extension versions #463
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @danieldietrich! This change looks good to me and I'm happy to approve!
However, I think we should keep #449 to track the task of supporting more current node versions.
Also, I think we should mention in the readme that building locally requires node 14.x.
Thank you!
Thank you for the quick reply @planger!
That makes absolutely sense to me!
Yep, I've missed that. I've added another commit. Thank you Philip & have a nice weekend |
@planger I recognized that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for the fast turnaround! I just made a suggestion to mention that ignoring peer dependency conflicts works too.
I think it would make sense to commit the modified package-lock.json
. Thank you!
Co-authored-by: Philip Langer <[email protected]>
Great! All changes are in place now. |
Avoid #449 when using Gitpod by setting node version v14 aka lts/fermium (currently npm version 6.14.18)
@planger however ... I understand that it does not really fix the original issue of supporting newer node/npm versions. this is just a quick fix to be able to contribute to the current site