Add autoClosingPairs field to LanguageConfiguration API #13088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tortmayr a smallish one for the 1.83.1 vscode compat. |
tsmaeder
force-pushed
the
13060_autoclosing_pairs
branch
from
0b56533
to
8dcc958
Compare
|
Here's the vsix: and here's the source: |
tortmayr
approved these changes
Nov 28, 2023
|
@tsmaeder Conflicts need to be resolved before we can merge this |
Contributed on behalf of STMicroelectronics Signed-off-by: Thomas Mäder <[email protected]>
Signed-off-by: Thomas Mäder <[email protected]>
tsmaeder
force-pushed
the
13060_autoclosing_pairs
branch
from
a49d731
to
1c50d36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #13060
Contributed on behalf of STMicroelectronics
How to test
The attached extension contributes a command "Set Closing Pairs". It sets the closing pairs for the
typescriptlanguage to "asdf"/"fdsa", but only in strings. After invoking it, when you typeasdfinside a string, the stringfdsawill be inserted, but only if there is a space after the insert location.Review checklist
Reminder for reviewers