Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform yarn upgrade #13748

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Perform yarn upgrade #13748

wants to merge 1 commit into from

Conversation

jfaltermeier
Copy link
Contributor

@jfaltermeier jfaltermeier commented Jun 3, 2024

What it does

The commit performs a yarn upgrade of the framework to better
represent what downstream applications pull with our version ranges, and
to resolve known security vulnerabilities which were pulled by our
lockfile. The changes also make sure that our declared ranges for
dependencies are correct and fixes any compilation errors.

Contributed on behalf of STMicroelectronics

How to test

Check for any regressions, especially for the components that needed compile fixes.

Review checklist

Reminder for reviewers

@jfaltermeier jfaltermeier force-pushed the jf/yarn-upgrade branch 3 times, most recently from 72b68f1 to b5c2815 Compare June 6, 2024 11:01
@jfaltermeier jfaltermeier changed the title WIP Perform yarn upgrade Perform yarn upgrade Jun 6, 2024
@jfaltermeier jfaltermeier force-pushed the jf/yarn-upgrade branch 2 times, most recently from 082de2a to 88b8c3b Compare June 6, 2024 11:20
@jfaltermeier jfaltermeier marked this pull request as ready for review June 6, 2024 11:46
package.json Outdated Show resolved Hide resolved
@MatthewKhouzam
Copy link

Hey, this is really cool. Just wanted to say thanks!

@JonasHelming
Copy link
Contributor

@jfaltermeier What is the state of this?

@jfaltermeier
Copy link
Contributor Author

The license check does not complete because the IP team has not yet reviewed the upgraded vsce-sign-* packages. See links above.

@marcdumais-work
Copy link
Contributor

marcdumais-work commented Sep 25, 2024

The license check does not complete because the IP team has not yet reviewed the upgraded vsce-sign-* packages. See links above.

The IP check for this is a bit complicated and could potentially take a while. Looking quickly in this repo, how @vscode/vsce is used, I think you have a good case to be granted "works with" approval for the vsce-sign-* packages:

Searching in the repo, the only use made of vsce is to package test plugins (vscode extensions), that are not published to the Visual Studio Marketplace or even openvsx, AFAIK:

image

What I would do:

  • Manually open a single IP ticket about the @vscode/vsce-sign-* and explain the limited way vsce is used in this project. I expect you will be granted a "works with" project-wide permission for these dependencies.
  • if the license check still fails on some or all of them, add the corresponding npm packages in the exclude file, adding for each a link to the IP ticket where you got approval to use the dependencies: https://github.com/eclipse-theia/theia/blob/master/dependency-check-baseline.json
  • the license check should now pass

@JonasHelming
Copy link
Contributor

@marcdumais-work Thank you very much! @jfaltermeier FYI

@marcdumais-work
Copy link
Contributor

marcdumais-work commented Sep 25, 2024

@jfaltermeier Alternatively, and probably quicker, another option would be to use a slightly older version of vsce, that does not pull the `vsce-sign* packages:

Update root package.json to depend on [email protected]. If that's not enough, you might pin the version by adding an entry in the resolutions block in the same file, "@vscode/vsce": "2.25.0".

I would suggest doing this for now, but maybe still going forward with the suggestion to open a Theia-specific IP ticket, for the longer term, since you may not want to use an older vsce forever.

The commit performs a `yarn upgrade` of the framework to better
represent what downstream applications pull with our version ranges, and
to resolve known security vulnerabilities which were pulled by our
lockfile. The changes also make sure that our declared ranges for
dependencies are correct and fixes any compilation errors.

Contributed on behalf of STMicroelectronics
@jfaltermeier
Copy link
Contributor Author

I've pinned it to 2.25.0 now and opened a ticket regarding the works-with approval: https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/16445.

Now the license check is failing for npm/npmjs/-/electron-to-chromium/1.5.13. We've seen this happen in other projects as well, starting mid/end of last month - license checks that were green are now failing because of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Waiting on reviewers
Development

Successfully merging this pull request may close these issues.

5 participants