New File dialog doesn't accept Enter for default

[dhuebner]

What it does

Allow to accept the File Dialog by pressing Enter and canceling by pressing Escape.

See #13582

How to test

In theia-main-menu.test.ts the "Create file via New File menu and accept" test uses Enter to accept the File Dialog an save a file.

Or follow the description in #13582

Follow-ups

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

[tsmaeder]

@dhuebner is this a problem on Mac only? I can accept the file dialog with enter on Windows.

[dhuebner]

@tsmaeder
No, I don't think it is Mac specific. The problem was, that the tree widget eats the Enter and ESC key stroke events so that the dialog can not be closed using keyboard. One need to click on the corresponding buttons or use TAB to jump to them and then hit Enter.

[dhuebner]

@tsmaeder
Now, I see. You need to use the menu "File" -> "New File...". Then save the untitled file and you will get this dialog.

[tsmaeder]

That's what I'm doing: in the video, I just press "Enter" when the "Save as"-dialog opens. What am I missing?

2024-10-11.11-43-22.mp4

[dhuebner]

@tsmaeder
The problem only occurs when running in the browser. In the electron version the system dialog is used and works fine.
Sorry for the confusion, I need to better explain how to test.

[tsmaeder]

Seems to do the trick. I'm still not convinced we should not handle the keyboard focus differently, but that's a larger discussion.

[dhuebner]

@tsmaeder
Thank you for the review!