Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes the cell editor border grey when not focused #14195

Merged

Conversation

dhuebner
Copy link
Contributor

What it does

Currently if a code cell is selected (Blue line on the lefthand side) but the cell editor itself has no focus - the editor has a focused (blue) border. This change makes the editor outline/border grey is the cell editor doesn't have focus.

How to test

Open a notebook and select a cell editor. The editor should have a focus (blue) border. Press ESC - it turns off the edit mode and editor lose focus. The editor border should become grey.

Follow-ups

Review checklist

Reminder for reviewers

Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this fixes the issue with the editor, the cell sidebar still has the blue highlight color:

image

In VS Code, the cell side bar marker becomes "inactive":

image

@dhuebner
Copy link
Contributor Author

dhuebner commented Sep 19, 2024

While this fixes the issue with the editor, the cell sidebar still has the blue highlight color:

It is the intended behavior. Wenn pressing ESC only the editor should be turned into non-edit state. The cell itself should remain selected.

In VS Code, the cell side bar marker becomes "inactive":

Not in my vs-code. Pressing ESC turns off the editor focus, pressing ENTER activates the editor again. The side bar all the time shows "selected" state.

What you maybe see, is when mouse-click somewhere outside a cell in the editor, the last selected cell is still active (marked focused). This was before this change and is not a part of the fix.

@msujew msujew added the notebook issues related to notebooks label Sep 19, 2024
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see. Thanks for the explanation. Then everything works as expected 👍

@msujew msujew merged commit b8ecd13 into eclipse-theia:master Sep 19, 2024
11 checks passed
@sgraband sgraband added this to the 1.54.0 milestone Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notebook issues related to notebooks
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants