[vscode] TreeView reveal options are now readonly #14198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes eclipse-theia#14109 Contributed on behalf of STMicroelectronics Signed-off-by: Remi Schnekenburger <[email protected]>
rschnekenbu
force-pushed
the
issues/14109
branch
from
20dada6
to
fa87b15
Compare
tsmaeder
reviewed
Sep 20, 2024
packages/plugin/src/theia.d.ts
Outdated
| * | ||
| * **NOTE:** {@link TreeDataProvider TreeDataProvider} is required to implement {@link TreeDataProvider.getParent getParent} method to access this API. | ||
| * * *NOTE:* You can expand only to 3 levels maximum. |
There was a problem hiding this comment.
Is this restriction true in Theia?
There was a problem hiding this comment.
I thought I had changed the comment. This is now fixed with new commit.
tsmaeder
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Since vscode 1.93, TreeView#reveal options are now readonly. The same was applied to theia.d.ts and TreeViewRevealOptions from plugin api rpc.
No changes were expected from anywhere in the code. These are simple options on how to reveal elements
fixes #14109
contributed on behalf of STMicroelectronics
How to test
You can use the following vscode extension sample to test the reveal in a tree view. It provides 2 commands (
Test View: revealandTest View: reveal and selectthat invokes the reveal() API on sample tree view. The sample tree view contains various elements labeled a, aa, aaa, etc and b, bb.Follow-ups
none known
Review checklist
Reminder for reviewers