Fix window maximization when using splash screen #14219
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid eager restore of maximized state in `TheiaElectronWindow.init` when a splash screen is configured (i.e. `preventAutomaticShow` config option is false) Calling `window.maximize()` implicity also makes the window visibile. If `preventAutomaticShow` is true we have to make sure to invoke `restoreMaximizeState` after the main window is ready. Otherwise both the splashscreen and the preload window will be visible at the same time Fixes eclipse-theia#14218
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Avoid eager restore of maximized state in
TheiaElectronWindow.initwhen a splash screen is configured (i.e.preventAutomaticShowconfig option is false)Calling
window.maximize()implicity also makes the window visibile. IfpreventAutomaticShowis true we have to make sure to invokerestoreMaximizeStateafter the main window is ready. Otherwise both the splashscreen and the preload window will be visible at the same timeFixes #14218
How to test
Only the splash screen should be shown, main window should remain invisible until the splash screen is hidden.
Follow-ups
Review checklist
Reminder for reviewers