Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to order and clear AI History view #14233

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

JonasHelming
Copy link
Contributor

fixed #14183

What it does

Adds toolbar item to the AI History View allowing to clear the history and oder the view chronologically and reverse chronologically

How to test

Enter requests in the chat, e.g. 1, 2, 3
Sort the entries in the History View
Clear the History View

Review checklist

Reminder for reviewers

@JonasHelming JonasHelming marked this pull request as draft September 30, 2024 06:51
@JonasHelming JonasHelming removed the request for review from sdirix September 30, 2024 06:51
Copy link
Contributor

@eneufeld eneufeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorting and clearing works great.
But if i close the view I can't reopen it.
I have no idea how to test the state restore otherwise
Otherwise I have some code comments

packages/ai-history/src/browser/ai-history-contribution.ts Outdated Show resolved Hide resolved
packages/ai-history/src/browser/ai-history-contribution.ts Outdated Show resolved Hide resolved
packages/ai-history/src/browser/ai-history-contribution.ts Outdated Show resolved Hide resolved
packages/ai-history/src/browser/ai-history-contribution.ts Outdated Show resolved Hide resolved
packages/ai-history/src/browser/ai-history-contribution.ts Outdated Show resolved Hide resolved
packages/ai-history/src/browser/ai-history-widget.tsx Outdated Show resolved Hide resolved
packages/ai-history/src/browser/ai-history-widget.tsx Outdated Show resolved Hide resolved
packages/ai-history/src/browser/ai-history-widget.tsx Outdated Show resolved Hide resolved
Signed-off-by: Jonas Helming <[email protected]>
@JonasHelming
Copy link
Contributor Author

For the "reopen History view" bug, see: #14236
You can state the state by reloading.

Signed-off-by: Jonas Helming <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Waiting on reviewers
Development

Successfully merging this pull request may close these issues.

[Theia AI] Allow to reverse order History view (147)
3 participants