-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to order and clear AI History view #14233
Open
JonasHelming
wants to merge
3
commits into
master
Choose a base branch
from
GH-14183-2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed #14183 Signed-off-by: Jonas Helming <[email protected]>
JonasHelming
force-pushed
the
GH-14183-2
branch
from
September 30, 2024 09:43
3079381
to
ecba028
Compare
eneufeld
reviewed
Sep 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorting and clearing works great.
But if i close the view I can't reopen it.
I have no idea how to test the state restore otherwise
Otherwise I have some code comments
Signed-off-by: Jonas Helming <[email protected]>
For the "reopen History view" bug, see: #14236 |
Signed-off-by: Jonas Helming <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #14183
What it does
Adds toolbar item to the AI History View allowing to clear the history and oder the view chronologically and reverse chronologically
How to test
Enter requests in the chat, e.g. 1, 2, 3
Sort the entries in the History View
Clear the History View
Review checklist
Reminder for reviewers