Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate text editor entry #14238

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Conversation

msujew
Copy link
Member

@msujew msujew commented Oct 1, 2024

What it does

Closes #14237

Fixes the issue by correctly rebinding the EditorPreviewManager, thereby preventing the @postConstruct method to run twice. Also removes an unnecessary @inject of the EditorPreviewManager.

Lastly, prevents duplicate entries from appearing in the OpenWithService.

How to test

Follow the steps from #14237 and ensure that the entry is only shown once.

Review checklist

Reminder for reviewers

@msujew msujew added the ui/ux issues related to user interface / user experience label Oct 1, 2024
@msujew msujew requested a review from sdirix October 1, 2024 17:30
@msujew
Copy link
Member Author

msujew commented Oct 1, 2024

cc @sdirix since the Theia AI change broke it ;)

Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix and the additional improvements contained therein. I tested with and without the patch and can confirm that the issue is fixed.

@sdirix
Copy link
Member

sdirix commented Oct 2, 2024

FYI we intend to get rid of the AIEditorManager soon. It's one of the items listed in #14143

@msujew msujew merged commit 915c8ea into master Oct 2, 2024
11 checks passed
@msujew msujew deleted the msujew/fix-double-text-editor branch October 2, 2024 07:12
@github-actions github-actions bot added this to the 1.55.0 milestone Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/ux issues related to user interface / user experience
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Text editor is shown twice for "open with"
2 participants