Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: do not expose the TD ID via AugmentedForms #209

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

JKRhb
Copy link
Member

@JKRhb JKRhb commented Jan 12, 2025

As discussed in eclipse-thingweb/node-wot#1342, this PR removes the tdIdentifierthat has previously been exposed by the AugmentedForm class.

@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2025

Codecov Report

Attention: Patch coverage is 62.50000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 63.20%. Comparing base (fdc099a) to head (737bc39).

Files with missing lines Patch % Lines
lib/src/binding_coap/coap_client.dart 0.00% 4 Missing ⚠️
lib/src/binding_http/http_client.dart 0.00% 3 Missing ⚠️
lib/src/binding_http/http_subscription.dart 0.00% 1 Missing ⚠️
lib/src/binding_mqtt/mqtt_client.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #209      +/-   ##
==========================================
- Coverage   63.23%   63.20%   -0.04%     
==========================================
  Files          79       79              
  Lines        2312     2310       -2     
==========================================
- Hits         1462     1460       -2     
  Misses        850      850              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JKRhb JKRhb force-pushed the augmented-form-adjustment branch from dc73eac to 06700a2 Compare January 27, 2025 17:19
@JKRhb JKRhb force-pushed the augmented-form-adjustment branch from 314eab9 to 737bc39 Compare January 27, 2025 18:02
@JKRhb
Copy link
Member Author

JKRhb commented Jan 27, 2025

This PR now also simplifies the handling of the href field in AugmentedForms, as URI variables are resolved before the form is handed over to the protocol binding implementations and exposed as the regular href, making this transparent on the implementation side.

@JKRhb JKRhb marked this pull request as ready for review January 27, 2025 18:12
@JKRhb JKRhb merged commit 2e4e5c1 into main Jan 27, 2025
5 checks passed
@JKRhb JKRhb deleted the augmented-form-adjustment branch January 27, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants