-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to TypeScript 5.x #1343
Upgrade to TypeScript 5.x #1343
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1343 +/- ##
==========================================
- Coverage 78.56% 77.73% -0.83%
==========================================
Files 83 83
Lines 16587 16588 +1
Branches 1613 1609 -4
==========================================
- Hits 13031 12895 -136
- Misses 3532 3662 +130
- Partials 24 31 +7 ☔ View full report in Codecov by Sentry. |
About coap issue, I've opened a PR there: coapjs/node-coap#392 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @relu91 👍.
The changes look good, I have just one comment...
I just released a new patch release 1.4.1 containing the changes from coapjs/node-coap#392 that should resolve this aspect :) |
Just upgraded coap too. Everything should be ready to be merged, @danielpeintner . |
This is the final step of the work, which started a few months ago, to renovate the whole toolchain and build targets of node-wot. This PR focuses on upgrading to the latest typescript stable version. Main points: