Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to TypeScript 5.x #1343

Merged

Conversation

relu91
Copy link
Member

@relu91 relu91 commented Jan 17, 2025

This is the final step of the work, which started a few months ago, to renovate the whole toolchain and build targets of node-wot. This PR focuses on upgrading to the latest typescript stable version. Main points:

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.73%. Comparing base (d534535) to head (e55f6b0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1343      +/-   ##
==========================================
- Coverage   78.56%   77.73%   -0.83%     
==========================================
  Files          83       83              
  Lines       16587    16588       +1     
  Branches     1613     1609       -4     
==========================================
- Hits        13031    12895     -136     
- Misses       3532     3662     +130     
- Partials       24       31       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@relu91
Copy link
Member Author

relu91 commented Jan 17, 2025

About coap issue, I've opened a PR there: coapjs/node-coap#392

Copy link
Member

@danielpeintner danielpeintner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @relu91 👍.
The changes look good, I have just one comment...

packages/binding-coap/tsconfig.json Outdated Show resolved Hide resolved
packages/examples/tsconfig.json Show resolved Hide resolved
@JKRhb
Copy link
Member

JKRhb commented Jan 21, 2025

I just released a new patch release 1.4.1 containing the changes from coapjs/node-coap#392 that should resolve this aspect :)

@relu91
Copy link
Member Author

relu91 commented Jan 21, 2025

Just upgraded coap too. Everything should be ready to be merged, @danielpeintner .

@danielpeintner danielpeintner merged commit 2b1e766 into eclipse-thingweb:master Jan 22, 2025
14 checks passed
@relu91 relu91 deleted the chore/upgrade-to-ts-5-x branch January 22, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants