Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update guix studio installer #106

Merged
merged 6 commits into from
Feb 22, 2024
Merged

Update guix studio installer #106

merged 6 commits into from
Feb 22, 2024

Conversation

bo-ms
Copy link
Contributor

@bo-ms bo-ms commented Feb 21, 2024

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 21, 2024 •
edited
Loading

Test Results GUIX Studio Demo

227 tests  ±0   227 ✅ ±0   23m 12s ⏱️ -54s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit f264eb1. ± Comparison against base commit 7b507fa.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 21, 2024 •
edited
Loading

Test Results GUIX Studio Demo Compile

212 tests  ±0   212 ✅ ±0   18m 22s ⏱️ -9s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit f264eb1. ± Comparison against base commit 7b507fa.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 21, 2024 •
edited
Loading

Test Results GUIX

1 841 tests  ±0   1 841 ✔️ ±0   31m 32s ⏱️ ±0s
     18 suites ±0          0 💤 ±0 
     18 files   ±0          0 ❌ ±0 

Results for commit f264eb1. ± Comparison against base commit 7b507fa.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 21, 2024 •
edited
Loading

Code Coverage

Package Line Rate Branch Rate Health
default_build_coverage Package 1 100% 100% ✔
Summary 100% (44324 / 44406) 100% (24236 / 24346) ✔

@bo-ms bo-ms marked this pull request as ready for review February 21, 2024 10:23
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 21, 2024 •
edited
Loading

Test Results GUIX Studio View

40 tests  ±0   40 ✅ ±0   1h 21m 11s ⏱️ +3s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit f264eb1. ± Comparison against base commit 7b507fa.

♻️ This comment has been updated with latest results.

wickste
wickste requested changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@wickste wickste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update per comments

guix_studio/build/vs_2019/msix_package_project/Package.appxmanifest Outdated Show resolved Hide resolved
guix_studio/installer/guix_installer_release.iss Outdated Show resolved Hide resolved
guix_studio/installer/guix_installer_release.iss Outdated Show resolved Hide resolved
guix_studio/installer/guix_installer_release.iss Outdated Show resolved Hide resolved
guix_studio/studiox.cpp Outdated Show resolved Hide resolved
@wickste wickste merged commit bf30b3a into master Feb 22, 2024
5 checks passed
@bo-ms bo-ms deleted the bo-ms/update_installer branch February 28, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wickste wickste wickste approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bo-ms @wickste