Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Pool): returning incomplete task results #1174

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Conversation

nicoprow
Copy link
Contributor

Description

Pool now correctly resolves tasks by providing business partner data based on the database state. This prevents returning inconsistent data.

Fixes #1158

You can have a look at #1158 for seeing how to test this fix.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@nicoprow nicoprow added the bug Something isn't working label Jan 13, 2025
@nicoprow nicoprow added this to the BPDM v6.3.0 / R25.03. milestone Jan 13, 2025
@nicoprow nicoprow marked this pull request as ready for review January 13, 2025 08:38
@nicoprow nicoprow force-pushed the fix/pool-task-results branch from b6911e1 to 8678f53 Compare January 24, 2025 03:56
@SujitMBRDI SujitMBRDI force-pushed the fix/pool-task-results branch from 8678f53 to d8495ec Compare January 27, 2025 06:39
Pool now correctly resolves tasks by providing business partner data based on the database state. This prevents returning inconsistent data

fix(bpdm-pool): updated E2E test and changelog
@SujitMBRDI SujitMBRDI force-pushed the fix/pool-task-results branch from d8495ec to abcd248 Compare January 27, 2025 07:04
Copy link
Contributor

@SujitMBRDI SujitMBRDI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes looked good to me.
I have added CHANGELOG details and also updated E2E test for expected result when business partner data is being shared with address type.

@SujitMBRDI SujitMBRDI merged commit 2d3ef33 into main Jan 27, 2025
17 checks passed
@nicoprow nicoprow deleted the fix/pool-task-results branch February 20, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gate output stage shows inconsistent BPNS information
2 participants