Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/charts/initcontainer memory cpu #1180

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

nicoprow
Copy link
Contributor

@nicoprow nicoprow commented Jan 14, 2025

Description

This pull request adds the missing resource definitions for CPU and memory requests to the BPDM deployments's initcontainers.

Fixes #1154

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@nicoprow nicoprow added this to the BPDM v6.3.0 / R25.03. milestone Jan 14, 2025
@nicoprow nicoprow added the enhancement New feature or request label Jan 14, 2025
@nicoprow nicoprow force-pushed the fix/charts/initcontainer-memory-cpu branch from c2f13ba to 4479c7e Compare February 5, 2025 02:01
@nicoprow nicoprow requested a review from SujitMBRDI February 5, 2025 03:03
@nicoprow nicoprow marked this pull request as ready for review February 5, 2025 03:03
@nicoprow nicoprow mentioned this pull request Feb 5, 2025
46 tasks
Copy link
Contributor

@SujitMBRDI SujitMBRDI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SujitMBRDI SujitMBRDI assigned nicoprow and unassigned SujitMBRDI Feb 5, 2025
@nicoprow nicoprow merged commit 590178b into main Feb 5, 2025
17 checks passed
@nicoprow nicoprow deleted the fix/charts/initcontainer-memory-cpu branch February 5, 2025 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chart's InitContainers Don't Specify CPU and Memory Limits
2 participants