-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bpdm-gate): added missing value for externalSequenceTimestamp attribute in response #1247
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Used the example of the linked issue to verify whether it works:
Gate PUT input/business-partners:
[
{
"externalId": "legalAddress_Vapiano_25.02.",
"nameParts": [
"VAP Marketing GmbH"
],
"identifiers": [
{
"type": "DE_BNUM",
"value": "Hildesheim HRB 207336"
}
],
"legalEntity": {
"legalEntityBpn": null,
"legalName": "VAP Marketing GmbH",
"shortName": null,
"legalForm": null
},
"site": {
"siteBpn": null,
"name": null
},
"address": {
"addressType": "LegalAddress",
"physicalPostalAddress": {
"administrativeAreaLevel1": null,
"city": "Hildesheim",
"country": "DE",
"industrialZone": null,
"postalCode": "31135",
"street": {
"houseNumber": "6",
"name": "Frankenstraße"
}
}
},
"externalSequenceTimestamp": "2025-02-25T14:13:46.550Z",
"isOwnCompanyData": false
}
]
response shows externalSequenceTimestamp successfully returned
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I have to redact the approval. Let's create a Changelog entry as well :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Omg, back to approval again. I just noticed this belongs to the new sig-release feature eclipse-tractusx/sig-release#726 and therefore will not need a separate fix entry (as the introduction of the externalSequenceTimestamp is already covered in the Changelog).
Hello @nicoprow, yes feature is not released yet. The reason why i haven't added changelog entry for bug observed. |
Description
This pull request adds missing value for
externalSequenceTimestamp
attribute in Gate input response.Fixes #1245
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: